-
Notifications
You must be signed in to change notification settings - Fork 3
edited session replays initialization #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌟 EkLine ReviewerHello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page. For questions or feedback, please email [email protected]. |
Published docs preview URL: https://devrev-preview-1f7fece2-8b76-45cd-8e21-0d32a1fafa88.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-dd58ab08-612c-4e95-a61d-82ee5affec4a.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-8e5ab5ac-f255-4d29-8d16-5ddc3d3eb629.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-9fc724a5-cfa0-4e53-8edd-a7b5997421f8.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-f38f63b1-efe8-4b41-859e-61ce41b88654.docs.buildwithfern.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some superficial questions/suggestions.
</Tab> | ||
<Tab title="Replace with PLuG"> | ||
```jsx | ||
{" "} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this line supposed to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this line came automatically when I saved the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But is it supposed to be there? What does it mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, this is not supposed to be here. I dont know how it came.
```jsx | ||
|
||
<script type="text/javascript" src="https://plug-platform.devrev.ai/static/plug.js"></script> | ||
```` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be 3 backticks not 4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it automatically became 4 backticks instead of 3 when I saved the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What editor or utility made it 4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am using prettier extension for auto formatting
</Tab> | ||
<Tab title="Replace with PLuG"> | ||
```jsx | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}); | ||
window.plugSDK.onEvent((payload) => { | ||
if (payload.type === 'ON_OBSERVABILITY_READY') { | ||
// code you want to execute after recording starts | ||
} | ||
}); | ||
``` | ||
|
||
```` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 backticks again.
|
||
```` | ||
|
||
(Note: To enable session recordings, go to Settings > Support > Session Replays and enable recordings for your desired platforms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Note: To enable session recordings, go to Settings > Support > Session Replays and enable recordings for your desired platforms) | |
<Note> | |
To enable session recordings, go to **Settings** > **Support** > **Session Replays** and enable recordings for your desired platforms. | |
</Note> |
}); | ||
``` | ||
|
||
```` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 backticks again.
Published docs preview URL: https://devrev-preview-b479e061-56f1-421f-aafe-b4ae6118ce15.docs.buildwithfern.com |
removed session_recording_enabled in plug initialisation method for enabling session recording.
https://app.devrev.ai/devrev/works/ISS-178091