Skip to content

edited session replays initialization #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

AvinashSingh10-1
Copy link
Contributor

removed session_recording_enabled in plug initialisation method for enabling session recording.

https://app.devrev.ai/devrev/works/ISS-178091

@AvinashSingh10-1 AvinashSingh10-1 requested a review from a team as a code owner May 29, 2025 12:47
Copy link
Contributor

github-actions bot commented May 29, 2025

🌟 EkLine Reviewer

Hello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page.

For questions or feedback, please email [email protected].

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@bc-devrev bc-devrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some superficial questions/suggestions.

</Tab>
<Tab title="Replace with PLuG">
```jsx
{" "}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line supposed to be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this line came automatically when I saved the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is it supposed to be there? What does it mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is not supposed to be here. I dont know how it came.

```jsx

<script type="text/javascript" src="https://plug-platform.devrev.ai/static/plug.js"></script>
````
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 3 backticks not 4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it automatically became 4 backticks instead of 3 when I saved the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What editor or utility made it 4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using prettier extension for auto formatting

</Tab>
<Tab title="Replace with PLuG">
```jsx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

});
window.plugSDK.onEvent((payload) => {
if (payload.type === 'ON_OBSERVABILITY_READY') {
// code you want to execute after recording starts
}
});
```

````
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 backticks again.


````

(Note: To enable session recordings, go to Settings > Support > Session Replays and enable recordings for your desired platforms)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(Note: To enable session recordings, go to Settings > Support > Session Replays and enable recordings for your desired platforms)
<Note>
To enable session recordings, go to **Settings** > **Support** > **Session Replays** and enable recordings for your desired platforms.
</Note>

});
```

````
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 backticks again.

Copy link
Contributor

@AvinashSingh10-1 AvinashSingh10-1 marked this pull request as draft May 30, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants