Skip to content

ISS-120468: Update documentation for the marketplace related commands #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 1, 2024

Conversation

MhcVintar
Copy link
Contributor

Added documentation regarding marketplace listings.

https://app.devrev.ai/devrev/works/ISS-120468

@MhcVintar MhcVintar requested a review from a team as a code owner September 25, 2024 13:22
Copy link
Contributor

@bc-devrev bc-devrev added the No EkLine Skip EkLine automated QA label Sep 25, 2024
Copy link
Contributor

🌟 EkLine Reviewer

Hello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page.

For questions or feedback, please email [email protected].

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

EkLine

🚫 [EkLine] reported by reviewdog 🐶

Prefer English terms over Latin abbreviations. Use 'for example' instead of 'e.g.'. (EK00026)

properties (e.g. name, description, icon, etc.).


📝 [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

To create a new marketplace listing, run the following command, which will start a __wizard__ to guide you through the


📝 [EkLine] reported by reviewdog 🐶

Suggestions:

    Avoid using 'we' as it can come off as patronizing. For example, write 'The configuration is complete' rather than 'We are now done with the configuration.' (EK81039)

state), we can modify the listing by creating a new submission. First we have to create a submission which we can later


📝 [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

To create a new submission for an existing marketplace listing, run the following command, which will start a __wizard__


📝 [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

Once a submission has been created, it can be updated by running the following command, which will start a __wizard__ to


📝 [EkLine] reported by reviewdog 🐶

Avoid using 'we' as it can come off as patronizing. For example, write 'The configuration is complete' rather than 'We are now done with the configuration.' (EK81039)

The newly created marketplace submission is in the `draft` state. In order to publish it, we first have to transition it


📝 [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

to`waiting_for_review` state. This can be done by running the following command, which will start a __wizard__ to guide


📝 [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

While in review, the state of the submission is `in_review`. Once it is reviewed, the state will be changed to either


📝 [EkLine] reported by reviewdog 🐶

Avoid using 'we' as it can come off as patronizing. For example, write 'The configuration is complete' rather than 'We are now done with the configuration.' (EK81039)

If the submission was rejected, we can transition it back to `draft` state and modify it to satisfy the requirements.


📝 [EkLine] reported by reviewdog 🐶

Avoid using 'we' as it can come off as patronizing. For example, write 'The configuration is complete' rather than 'We are now done with the configuration.' (EK81039)

Once the submission is updated, we can transition it back to `waiting_for_review` state to be reviewed again.


📝 [EkLine] reported by reviewdog 🐶

Suggestions:

  • Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
  • Avoid using 'we' as it can come off as patronizing. For example, write 'The configuration is complete' rather than 'We are now done with the configuration.' (EK81039)

If the submission was approved, we can publish it using the following command, which will start a __wizard__ to guide


📝 [EkLine] reported by reviewdog 🐶

Avoid using 'we' as it can come off as patronizing. For example, write 'The configuration is complete' rather than 'We are now done with the configuration.' (EK81039)

To make sure that marketplace item was published we can retrieve it using its ID:


📝 [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

the `draft` or `rejected` state. You can delete a submission using the following command, which will start a __wizard__


📝 [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

Once a new version for a marketplace-item is published, the respective Snap-Ins will be auto-upgraded to the latest


🚫 [EkLine] reported by reviewdog 🐶

Confirm the link. The URL 'https://github.com/devrev/snap-in-docs/blob/main/references/cli.md' seems inaccessible with error code 404. It might be incorrect or improperly formatted. (EK20001)

guide [visit here](https://github.com/devrev/snap-in-docs/blob/main/references/cli.md).


🚫 [EkLine] reported by reviewdog 🐶

Confirm the link. The URL 'https://github.com/devrev/snap-in-docs/blob/main/start.md' seems inaccessible with error code 404. It might be incorrect or improperly formatted. (EK20001)

Snap-Ins, [follow this guide here](https://github.com/devrev/snap-in-docs/blob/main/start.md), to create your first

@bc-devrev
Copy link
Contributor

Also address comments from EkLine.

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@MhcVintar MhcVintar requested a review from kosenina September 30, 2024 09:48
Copy link
Contributor

@bc-devrev bc-devrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two main things to fix before merging:

  • Put states in italics, not code phrase.
  • Don't use "we"; use "you" instead.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

@MhcVintar MhcVintar merged commit 5d7f984 into main Oct 1, 2024
2 checks passed
@MhcVintar MhcVintar deleted the ISS-120468-marketplace-listings branch October 1, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No EkLine Skip EkLine automated QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants