Skip to content

Fix: Update topic map config name #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Fix: Update topic map config name #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0acf319
Update topic map config name
Nandy-006 Jun 5, 2024
da2d87b
Update config value
Nandy-006 Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions source/src/main/java/com/trustpilot/connector/dynamodb/DynamoDBSourceConnectorConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ public class DynamoDBSourceConnectorConfig extends AbstractConfig {
public static final String DST_TOPIC_PREFIX_DISPLAY = "Topic prefix";
public static final String DST_TOPIC_PREFIX_DEFAULT = "dynamodb-";

public static final String DST_TOPIC_NAMESPACE_MAP_CONFIG = "kafka.topic.namespace.map";
public static final String DST_TOPIC_NAMESPACE_MAP_DOC = "Define Kafka topic namespace map.";
public static final String DST_TOPIC_NAMESPACE_MAP_DISPLAY = "Topic namespace map";
public static final String DST_TOPIC_NAMESPACE_MAP_DEFAULT = null;
public static final String DST_TOPIC_MAP_CONFIG = "kafka.topic.map";
public static final String DST_TOPIC_MAP_DOC = "Define Kafka topic namespace map.";
public static final String DST_TOPIC_MAP_DISPLAY = "Topic namespace map";
public static final String DST_TOPIC_MAP_DEFAULT = null;

public static final String REDISCOVERY_PERIOD_CONFIG = "connect.dynamodb.rediscovery.period";
public static final String REDISCOVERY_PERIOD_DOC = "Time period in milliseconds to rediscover stream enabled DynamoDB tables";
Expand Down Expand Up @@ -194,14 +194,14 @@ public static ConfigDef baseConfigDef() {
ConfigDef.Width.MEDIUM,
DST_TOPIC_PREFIX_DISPLAY)

.define(DST_TOPIC_NAMESPACE_MAP_CONFIG,
.define(DST_TOPIC_MAP_CONFIG,
ConfigDef.Type.STRING,
DST_TOPIC_NAMESPACE_MAP_DEFAULT,
DST_TOPIC_MAP_DEFAULT,
ConfigDef.Importance.HIGH,
DST_TOPIC_NAMESPACE_MAP_DOC,
DST_TOPIC_MAP_DOC,
CONNECTOR_GROUP, 2,
ConfigDef.Width.LONG,
DST_TOPIC_NAMESPACE_MAP_DISPLAY)
DST_TOPIC_MAP_DISPLAY)

.define(SRC_INIT_SYNC_DELAY_CONFIG,
ConfigDef.Type.INT,
Expand Down Expand Up @@ -262,8 +262,8 @@ public String getDestinationTopicPrefix() {
return getString(DST_TOPIC_PREFIX_CONFIG);
}

public String getDestinationTopicNamespaceMap() {
return getString(DST_TOPIC_NAMESPACE_MAP_CONFIG);
public String getDestinationTopicMap() {
return getString(DST_TOPIC_MAP_CONFIG);
}

public long getRediscoveryPeriod() {
Expand Down
2 changes: 1 addition & 1 deletion source/src/main/java/com/trustpilot/connector/dynamodb/DynamoDBSourceTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public void start(Map<String, String> configProperties) {
tableDesc.getTableName(),
tableDesc.getProvisionedThroughput().getReadCapacityUnits());
}
converter = new RecordConverter(tableDesc, config.getDestinationTopicPrefix(), config.getDestinationTopicNamespaceMap());
converter = new RecordConverter(tableDesc, config.getDestinationTopicPrefix(), config.getDestinationTopicMap());

LOGGER.info("Starting background KCL worker thread for table: {}", tableDesc.getTableName());

Expand Down