Skip to content

Add flag to disable init sync #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Add flag to disable init sync #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions source/src/main/java/com/trustpilot/connector/dynamodb/DynamoDBSourceConnectorConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ public class DynamoDBSourceConnectorConfig extends AbstractConfig {
public static final String SRC_INIT_SYNC_DELAY_DISPLAY = "INIT_SYNC delay";
public static final int SRC_INIT_SYNC_DELAY_DEFAULT = 60;

public static final String SRC_INIT_SYNC_ENABLE_CONFIG = "init.sync.enable";
public static final String SRC_INIT_SYNC_ENABLE_DOC = "Define if INIT_SYNC should be enabled.";
public static final String SRC_INIT_SYNC_ENABLE_DISPLAY = "INIT_SYNC enable";
public static final boolean SRC_INIT_SYNC_ENABLE_DEFAULT = false;

public static final String AWS_REGION_CONFIG = "aws.region";
public static final String AWS_REGION_DOC = "Define AWS region.";
public static final String AWS_REGION_DISPLAY = "Region";
Expand Down Expand Up @@ -223,16 +228,25 @@ public static ConfigDef baseConfigDef() {
SRC_INIT_SYNC_DELAY_DEFAULT,
ConfigDef.Importance.LOW,
SRC_INIT_SYNC_DELAY_DOC,
CONNECTOR_GROUP, 2,
CONNECTOR_GROUP, 4,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this imply?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ordering of params?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, ordering of params in a group. higher order takes more priority. if the same config, higher order is preferred over lower order.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameter of apache config.

ConfigDef.Width.MEDIUM,
SRC_INIT_SYNC_DELAY_DISPLAY)

.define(SRC_INIT_SYNC_ENABLE_CONFIG,
ConfigDef.Type.BOOLEAN,
SRC_INIT_SYNC_ENABLE_DEFAULT,
ConfigDef.Importance.LOW,
SRC_INIT_SYNC_ENABLE_DOC,
CONNECTOR_GROUP, 3,
ConfigDef.Width.MEDIUM,
SRC_INIT_SYNC_ENABLE_DISPLAY)

.define(REDISCOVERY_PERIOD_CONFIG,
ConfigDef.Type.LONG,
REDISCOVERY_PERIOD_DEFAULT,
ConfigDef.Importance.LOW,
REDISCOVERY_PERIOD_DOC,
CONNECTOR_GROUP, 4,
CONNECTOR_GROUP, 5,
ConfigDef.Width.MEDIUM,
REDISCOVERY_PERIOD_DISPLAY)
;
Expand Down Expand Up @@ -289,6 +303,10 @@ public int getInitSyncDelay() {
return (int)get(SRC_INIT_SYNC_DELAY_CONFIG);
}

public boolean getInitSyncEnable() {
return getBoolean(SRC_INIT_SYNC_ENABLE_CONFIG);
}

public String getDynamoDBServiceEndpoint() {
return getString(AWS_DYNAMODB_SERVICE_ENDPOINT_CONFIG);
}
Expand Down
12 changes: 9 additions & 3 deletions source/src/main/java/com/trustpilot/connector/dynamodb/DynamoDBSourceTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ public class DynamoDBSourceTask extends SourceTask {
private SourceInfo sourceInfo;
private TableDescription tableDesc;
private int initSyncDelay;
private boolean initSyncEnabled = false;

@SuppressWarnings("unused")
//Used by Confluent platform to initialize connector
Expand Down Expand Up @@ -123,6 +124,7 @@ public void start(Map<String, String> configProperties) {
tableDesc = client.describeTable(config.getTableName()).getTable();

initSyncDelay = config.getInitSyncDelay();
initSyncEnabled = config.getInitSyncEnable();

LOGGER.debug("Getting offset for table: {}", tableDesc.getTableName());
setStateFromOffset();
Expand Down Expand Up @@ -163,7 +165,11 @@ private void setStateFromOffset() {
} else {
LOGGER.debug("No stored offset found for table: {}", tableDesc.getTableName());
sourceInfo = new SourceInfo(tableDesc.getTableName(), clock);
sourceInfo.startInitSync(); // InitSyncStatus always needs to run after adding new table
if (initSyncEnabled) {
sourceInfo.startInitSync(); // InitSyncStatus always needs to run after adding new table
} else{
sourceInfo.initSyncStatus = InitSyncStatus.FINISHED;
}
}
}

Expand Down Expand Up @@ -296,7 +302,7 @@ private List<SourceRecord> sync() throws Exception {
//
// NOTE2: KCL worker reads from multiple shards at the same time in a loop.
// Which means that there can be messages from various time instances (before and after init sync start instance).
if (isPreInitSyncRecord(arrivalTimestamp)) {
if (initSyncEnabled && isPreInitSyncRecord(arrivalTimestamp)) {
LOGGER.debug(
"Dropping old record to prevent another INIT_SYNC. ShardId: {} " +
"ApproximateArrivalTimestamp: {} CurrentTime: {}",
Expand All @@ -315,7 +321,7 @@ private List<SourceRecord> sync() throws Exception {
// * connector was down for some time
// * connector is lagging
// * connector failed to finish init sync in acceptable time frame
if (recordIsInDangerZone(arrivalTimestamp)) {
if (initSyncEnabled && recordIsInDangerZone(arrivalTimestamp)) {
sourceInfo.startInitSync();

LOGGER.info(
Expand Down