-
Notifications
You must be signed in to change notification settings - Fork 2
Switches to FastMCP and adds resource support #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saramaebee
wants to merge
20
commits into
devrev:main
Choose a base branch
from
saramaebee:3-separate-devrev-resources-into-distinct-resource-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Switches to FastMCP and adds resource support #12
saramaebee
wants to merge
20
commits into
devrev:main
from
saramaebee:3-separate-devrev-resources-into-distinct-resource-types
+4,371
−411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching to FastMCP
will add better debug info using fastmcp capabilities
pretty sure fastmcp has support for this
Issues and Timeline support
Thanks for preparing this patch @saramaebee!! The PR looks pretty huge, can you break this down into smaller chunks for better and faster review:
Keeping the PR small will ensure better & quicker reviews. Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why named it claude.md ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team, super excited to be working on this with you. I apologise for the major overhaul to the code here, I understand if you are hesitant to accept it off the bat.
While I researching MCPs to figure out how to best utilise it in my workflow, I found a few good reasons for switching to the FastMCP framework. The 1.0 version of FastMCP is found in the Python
mcp
SDK, but they've continued iterating on it and just launched 2.2.0.It has a lot of helpful features around logging/error handling/resource handling that I think will help us design a really useful tool.
The brunt of this PR was doing work to replace some scripts i'd been using to download ticket information (and comments/artifacts) for the LLM to analyze.
Please let me know if you have any questions. I've only just begun implementing some early stuff, I hope to add much deeper tooling as well.
Testing instructions
Things to try asking a model connected to it
Example of it in use