Update from original #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CharCounter now working with emojis (16-bit code) * Fixed review notes
* fix wheelpicker in android * Removed initialNumToRender, removed style * removed itemLength variable * opt-out * added flatListProps to wheelPicker.api * added note to the api.json file * refactor the nore * fixed note * minor fix
Allow sending multiple params and allow (any) objects
* Incubator.Dialog - fix test after RN71 bug fix * Forgot this
* Replacing 'react-native-text-size' with wix fork * fix version
* Enable TS check on demo files and fix all errors * Code review fixes * Add space - test commit * Remove space
* Move to reanimated 3 * Improve wording
* GradientSlider - adding 'migrate' prop to allow using Incubator Silder instead of old implementation * fix lint and ts * Slider - add the 'migrate' prop to use Incubator.Slider * Incubator.Slider - fix how we apply 'tumbTintColor' to match old Slider * Demo screen - add the 'migrate' prop * remove duplicate prop declaretion * comments * adding prop to api json * pr comments fix * example margins * removing migrate from old screen --------- Co-authored-by: M-i-k-e-l <[email protected]>
* iOS - set min deployment to iOS 13.0 * Demo - change bundle id to allow running on iOS device
* Support subtitle in Modal.TopBar * bodySmall
ColorPicker - add 'migrate' prop to use new SliderImplementation
* add ItemMargin prop * move height calculation * renaming * Prettify --------- Co-authored-by: M-i-k-e-l <[email protected]>
* TextField: forward containerId prop * code-review * code-review
* Fix the Wizard.Step style according to the guidelines * changed bottom divider color
* Release notes script - fix and improve * Move logic to functions * Move silentPRs * Oops * Error in red + align a little to private * Support input params * Rename to Additional info (and add to PR template) + improve error message
* Refactor Day component to not use animated styles * Remove unnecessary null check
* ColorPicker - allow theme * Add props Co-authored-by: Inbal Tish <[email protected]> --------- Co-authored-by: Inbal Tish <[email protected]>
* wheel picker onlayout fix * removed comments
* add testID for picker modal list * add testID for picker modal list * add testID for picker modal list * fix lint
* fix: [WEB] SvgImage update styles * fix sizing of svg wrapper * code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.