Cleanup account resource implementation #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now the test suite doesn't really catch memory corruption issues, we are still just returning arrays that points to out-of-scope stack memory. Which is really bad. |
sunmilee
approved these changes
Nov 15, 2019
|
Let's merge this in and can figure out how to catch memory issues |
sunmilee
reviewed
Nov 16, 2019
| delegated_key_rotation_capability: account_resource.delegated_key_rotation_capability, | ||
| delegated_withdrawal_capability: account_resource.delegated_withdrawal_capability, | ||
|
|
||
| let result = CDevAccountResource { |
thefallentree
pushed a commit
that referenced
this pull request
Sep 22, 2020
fix GetAccountStateResp for new testnet release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed authentication key into an fixed array. Also deleted unnecessary DevAccountResource type, updated test to pass