Skip to content

0.5.x Work in Progress #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 244 commits into from
Jan 25, 2018
Merged

0.5.x Work in Progress #194

merged 244 commits into from
Jan 25, 2018

Conversation

davidlehn
Copy link
Member

@davidlehn davidlehn commented Jul 26, 2017 •
edited
Loading

DO NOT MERGE: This is a work-in-progress PR tracking 0.5.x progress.

While under development the 0.5.x branch is being published to npm with the "dev" tag. 0.4.x will use the "latest" tag until 0.5.x is mature.
NOTE: This branch has been released as the "latest" npm tag as 0.5.17.

A main 0.5.x feature will be switching to a more modular system based on CommonJS and ES2015. Modularity was also done in #126. That effort went fully to ES modules. This attempt will likely start using CommonJS and have more functionality per file. As was done in the forge update, CommonJS is used for Node.js compatibility and webpack (or similar) will be used to create browser bundles.

  • Remove AMD/etc boilerplate.
  • Adadpt CommonJS style.
  • Top level options (as in forge) for native code control. jsonld.options.usePureJavaScript Used for at least allowing native SHA256 implementation.
  • webpack built browser bundles and testing. Set up to allow building custom bundles with just needed functionality. Aim towards future ES module design.
  • Browserify built bundles and testing.
  • Add docs on various tools and methods to create custom bundles
  • Testing: Node.js
  • Testing: In a browser manually via a webpack build of all tests
  • Testing: PhantomJS, Chrome, Firefox, and Safari via Karma (webpack version)
  • Testing: PhantomJS, Chrome, Firefox, and Safari via Karma (browserify version)
  • Testing: Travis-CI passing Node.js and PhantomJS tests
  • Docs updated
  • Style and misc cleanups
  • Drop Bower support? It's deprecated in favor of NPM. Much easier to only support built minimized bundles in NPM releases and magic NPM CDN hosting. Alternate is to do as forge does with secondary repo and complex release process. Make sure not to break bower usage (tags, etc).
  • Update local testing.
  • Improve support for local tests.
  • Remove as much old build/test cruft as possible.
  • Add some (not too slow) nodejs and web tests with jsonld.options.usePureJavaScript===true.
  • webpack vs node/browserify test count.
  • Check npm pack.
  • .editorconfig
  • 0.5.0 Milestone Issues

As this is a rather major change it needs testing and feedback before hitting master. Please test and leave comments, thanks!

@davidlehn davidlehn self-assigned this Jul 26, 2017
@davidlehn davidlehn added this to the v0.5.0 milestone Jul 26, 2017
mattcollier and others added 16 commits July 26, 2017 12:21
@mattcollier @davidlehn
Style fixes.
a321b4c
@davidlehn
Use webpack, use Karma, and update test runner.
e13d13f 
Removed:
- Bower support. Use NPM, a NPM proxy site, or build your own bundle.

Changed:
- Switch to Karma for browser testing.
- Switch to webpack to build browser bundles.
- Use async APIs for test generation.
  - Done to allow testing in Node.js and browsers.
  - Required major testing changes to make everything async.
  - Workarounds added to get async generated mocha tests working.
- Improved support for loading various types of tests.
  - Can load local files, test manifests, or plain js files (in Node.js).
- Use ES2015 in tests and babel/webpack to support older platforms.
@davidlehn
Update IDL test support files.
344037e 
- https://github.com/w3c/web-platform-tests/tree/master/resources
- https://github.com/w3c/web-platform-tests/tree/master/resources/webidl2/lib
- Keep patch to always add WebIDL2 to the window.
@davidlehn
Build fixes.
57c06ea 
- Add package files.
- Add prepublish script.
- Fixes.
@davidlehn
Remove test building support.
6f48663 
Karma config has it's own webpack rules.
@davidlehn
Remove unused resolve rules.
52ea619
@davidlehn
Add local test.
40fc4ca 
- Add done call.
- Add to node tests.
@davidlehn
Add url to error details.
9243d02
@davidlehn
Use INFO log level.
8fca927
@davidlehn
RIP Makefile.
7ff1b8c 
- Remove Makefile.
- Add scripts directly in package.json.
@davidlehn
Update test suite location support.
c36ee91 
- Add fetch-test-suites script to create shallow copies.
- Update travis support to use fetch-test-suites.
- Update README.
- Default to local ./test-suites/ else sibling dirs.
@davidlehn
Remove debugging.
4da9098
@davidlehn
Add index.js.
0d5325e
@davidlehn
Remove Bower support.
e9372b9
@davidlehn
Style fixes.
689373e
@davidlehn
Add unhandledRejection handler.
f6e6381
gkellogg and others added 28 commits January 9, 2018 13:03
@gkellogg @davidlehn
Don't expand non-string native values to node objects. As called for in
912db44 
json-ld/json-ld.org#558.
@gkellogg @davidlehn
If term type is explicit, use it even for native values.
7b2d597
@gkellogg @davidlehn
Add ChangeLog entry for native type value expansion.
b3798d4
@gkellogg @davidlehn
Use ![].includes() instead of [].indexOf === -1
9a505ac
@davidlehn
Fix changelog format.
9c37663
@davidlehn
Fix linting inputs.
07ba9a6
@davidlehn
Update dependencies.
7226b3b
@gkellogg @davidlehn
- Set processingMode from options or first encountered context.
53f0fb4 
- Use array representation of @container in processing.
- Improved error detection for @container variations.
@gkellogg @davidlehn
Put processingMode on the context, rather than the API.
6e10d86
@gkellogg @davidlehn
Use the &= style, instead of single-line if, as it is more concise.
6aa92e1
@gkellogg @davidlehn
Don't be so clever when setting processingMode.
9a8c0f2
@gkellogg @davidlehn
Update based on style comments.
ff65164
@gkellogg @davidlehn
Include Expansion test 0088 in tests buy updating skip regexp.
ad0740a 
(cherry picked from commit eb54804)
@davidlehn
Sort keywords.
97292bc
@gkellogg @davidlehn
Check for keys in term definition outside that expected: @container…
e23f78d 
…, `@id`, `@language`, `@reverse`, and `@type`. This also sets up for additional keywords in 1.1.
@gkellogg @davidlehn
Remove @nest bits that were inadvertently included.
af2eee9
@davidlehn
Update changelog.
ffb4ffa
@davidlehn
Handle empty and relative @base.
7439977
@davidlehn
Use scheme regex to detect absolute IRIs.
3dc7c5b
@davidlehn
Detect blank node ids with isAbsolute.
89ee090
@gkellogg @davidlehn
Remove shortcut for compactIri when iri is a keyword, which was pre…
fc3ba6b 
…venting cases when keyword alias had `@type` defined, as in Compact 0073.
@gkellogg @davidlehn
Preserve fast path for compacting keyword alaises.
e31e5f2
@gkellogg @davidlehn
"can may be" => "may be"
62651aa
@davidlehn
Update changelog.
90c6dd3
@davidlehn
Update dependencies.
f7b7d9f
@davidlehn
Update changelog.
e73a967
@davidlehn
Release 0.5.16.
7522a3e
@davidlehn
Start 0.5.17-0.
8d036d8
@davidlehn davidlehn merged commit 8d036d8 into master Jan 25, 2018
@davidlehn
Copy link
Member Author

This branch has been merged into master and released as npm "latest". Remaining items above will be added as issues and addressed in 0.5.x, 0.6.x, or later as appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidlehn davidlehn

Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@davidlehn @pietercolpaert @adambro @gkellogg @mattcollier @dlongley