Remove shortcut from compactIri when iri is a keyword #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…venting cases when keyword alias had `@type` defined, as in Compact 0073.
gkellogg
changed the title
compactIri when iri is a keyword
gkellogg
commented
Jan 22, 2018
lib/compact.js
Outdated
| } | ||
| return iri; | ||
| } | ||
|
|
There was a problem hiding this comment.
Another option would be to leave this in place, and exit quickly if an iri is found, and otherwise continue. That would allow for more complicated behavior, while keeping the typical case fast.
davidlehn
approved these changes
Jan 25, 2018
dlongley
approved these changes
Jan 25, 2018
lib/compact.js
Outdated
| return inverseCtx[iri]['@none']['@type']['@none']; | ||
| } | ||
| return iri; | ||
| // if term is a keyword, it can may be compacted to a simple alias |
There was a problem hiding this comment.
type: it can may be => it may be compacted
|
LGTM, just noticed a typo in a comment. |
This was referenced Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which was preventing cases when keyword alias had
@typedefined, as in Compact 0073.