Updates to indexing #334
Merged
Updates to indexing #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlongley
reviewed
Nov 15, 2019
| // If compactedItem contains a single entry | ||
| // whose key maps to @id, recompact without @type | ||
| if(Object.keys(compactedItem).length === 1 && '@id' in expandedItem) { | ||
| compactedItem = await api.compact({ |
There was a problem hiding this comment.
Can we just get the alias for @id here and pull out the value compactedItem[alias] without having to run compact again? Or is it the case that it could have used a different value based on the presence of @type (via scoped contexts or something?)
There was a problem hiding this comment.
Not easily, as if reduced to a node reference, it can be turned into a string. If not, it remains a node object. We could conceivably implement that logic there, but that's what expand is for, and it should be pretty quick in that case.
|
Modulo my comment this PR seems ok to me so far. @davidlehn ? |
davidlehn
reviewed
Nov 19, 2019
davidlehn
reviewed
Nov 19, 2019
davidlehn
reviewed
Nov 19, 2019
davidlehn
reviewed
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@typerequires@typeto be either@idor@vocab, and defaults to@id.@index.