@context resolution respects relative URLs. #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
gkellogg
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
With a push to ignore some @propagate tests added in w3c/json-ld-api#230, the only tests that fail without this PR are those added to test this feature. Using the change fixes that. IMO, the only issue is if it is stylistically acceptable.
dlongley
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Seems ok to me. I added a minor stylistic suggestion.
@davidlehn -- this PR look good to you?
Co-Authored-By: Dave Longley <[email protected]>
davidlehn
reviewed
Dec 3, 2019
| @@ -83,7 +83,7 @@ module.exports = ({ | |||
| const statusText = http.STATUS_CODES[res.statusCode]; | |||
| if(res.statusCode >= 400) { | |||
| throw new JsonLdError( | |||
| 'URL could not be dereferenced: ' + statusText, | |||
| `URL "${url}" could not be dereferenced: ${statusText}`, | |||
There was a problem hiding this comment.
This is a change from our usual style. URL is already a param in the details so could be omitted in the message text. Could also move the statusText to details.
There was a problem hiding this comment.
I'll merge PR, but may change this text later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. w3c/json-ld-api#228