Fixed prependBase
#384
Merged
Fixed prependBase
#384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be rebased after PR #381 is merged. |
gkellogg
added a commit
that referenced
this pull request
Apr 2, 2020
dlongley
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
AFAICT, this looks ok. I ran the URL parser against DID URLs and those have an authority of null, so no strange / chars should get injected into those.
@davidlehn -- we might want some future tests that include DID URLs if we don't have those already.
davidlehn
pushed a commit
that referenced
this pull request
Apr 9, 2020
davidlehn
pushed a commit
that referenced
this pull request
Apr 9, 2020
Fixed `prependBase` to start path with a '/' for a zero length path if there is an authority in base.
davidlehn
force-pushed
the
fix-prependBase
branch
from
cbb0517 to
17886c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to start path with a '/' for a zero length path if there is an authority in base.
For expand#t0129 and toRdf#te129.