Skip to content

Use package.json version field for EARL reports. #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Conversation

davidlehn
Copy link
Member

  • This worked with node and karma.
  • Is the 'v' prefix important?
  • Our versioning setup uses "3.0.2-0" for dev versions, so when creating real reports would want to checkout a released tag like v3.0.x first. (Or fake it by editing package.json)

Copy link
Collaborator

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the 'v' prefix important?

No, it doesn't matter at all.

Our versioning setup uses "3.0.2-0" for dev versions, so when creating real reports would want to checkout a released tag like v3.0.x first. (Or fake it by editing package.json)

Whatever you would like to see here.

@davidlehn davidlehn added this to the JSON-LD 1.1 milestone Apr 15, 2020
@davidlehn davidlehn added the bug label Apr 15, 2020
@davidlehn davidlehn merged commit 91a9a5e into master Apr 15, 2020
@davidlehn davidlehn deleted the earl-version branch April 15, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants