Skip to content

Fix template/snapshot tests #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2020
Merged

Fix template/snapshot tests #10

merged 3 commits into from
Nov 19, 2020

Conversation

d13r
Copy link
Contributor

@d13r d13r commented Nov 19, 2020 •
edited
Loading

  • Remove -d --update-snapshots (it effectively disables all snapshot tests! e.g. this test should have failed)
  • Normalise all line endings to LF instead
  • Add the missing snapshot for the new Tailwind view

@d13r d13r changed the title Fix template tests Fix template/snapshot tests Nov 19, 2020
@d13r
Copy link
Contributor Author

d13r commented Nov 19, 2020

BTW I would suggest configuring GitHub Actions to run the tests on pull requests too:

on: [push, pull_request]

https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#example-using-a-list-of-events

@shengslogar shengslogar self-assigned this Nov 19, 2020
@shengslogar shengslogar added bug Something isn't working housekeeping Project maintenance labels Nov 19, 2020
@shengslogar
Copy link
Member

Thanks, Dave! 🤗

@shengslogar shengslogar reopened this Nov 19, 2020
@shengslogar shengslogar merged commit abbdd2c into diglactic:main Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shengslogar shengslogar

Labels
bug Something isn't working housekeeping Project maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d13r @shengslogar