Skip to content

New template for Bootstrap 5 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 25, 2021
Merged

New template for Bootstrap 5 #16

merged 4 commits into from
Jan 25, 2021

Conversation

Kvaksrud
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #16 (bba782f) into main (7a4db95) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #16   +/-   ##
=========================================
  Coverage     90.62%   90.62%           
  Complexity       62       62           
=========================================
  Files             9        9           
  Lines           192      192           
=========================================
  Hits            174      174           
  Misses           18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4db95...55f6e42. Read the comment docs.

@shengslogar
Copy link
Member

Thanks for the PR. I'm hesitant to merge this in, since it's identical to the existing Bootstrap 4 template outside of the wrapping <nav> element. Is there something I'm missing here?

@unless ($breadcrumbs->isEmpty())
<ol class="breadcrumb">
@foreach ($breadcrumbs as $breadcrumb)
@if ($breadcrumb->url && !$loop->last)
<li class="breadcrumb-item"><a href="{{ $breadcrumb->url }}">{{ $breadcrumb->title }}</a></li>
@else
<li class="breadcrumb-item active">{{ $breadcrumb->title }}</li>
@endif
@endforeach
</ol>
@endunless

@shengslogar shengslogar self-assigned this Jan 25, 2021
@shengslogar shengslogar added the needsmoreinfo Extra attention is needed label Jan 25, 2021
@Kvaksrud Kvaksrud changed the title New template for MDB5 UI KIT (Bootstrap 5 & Material Design 2.0) New template for Bootstrap 5 Jan 25, 2021
@Kvaksrud
Copy link
Author

Renamed to Bootstrap 5 as it is based on it

@shengslogar
Copy link
Member

Thanks. I deleted my last comment because I noticed the Bootstrap 4 spec was actually supposed to have the wrapping <nav> but it didn't make it into our bootstrap4 template and I was thinking about consistency. We have wrapping elements in other templates, though, so this makes sense.

I'll merge this in and tag shortly. Thanks! 🚀

@shengslogar shengslogar merged commit 0271785 into diglactic:main Jan 25, 2021
@shengslogar shengslogar removed the needsmoreinfo Extra attention is needed label Jan 25, 2021
@Kvaksrud
Copy link
Author

Thanks! :)

@Kvaksrud Kvaksrud deleted the feature/mdb5-template branch January 25, 2021 18:40
@shengslogar
Copy link
Member

Tagged v6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants