Skip to content

Take delayed_job job_name from job #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vpolozov
Copy link

Problem

The current DelayedJob instrumentation extracts job names using only a regex pattern,
which often results in empty job names even when the actual job name is available.

Solution

Improved the job name extraction by:

  • First attempting the original regex approach
  • Falling back to get the name from payload_object if needed

Details

::Delayed::Job has name method which calls payload_object.display_name See <delayed_job>/lib/delayed/backend/base.rb

`::Delayed::Job` has `name` method which calls `payload_object.display_name` 
See `<delayed_job>/lib/delayed/backend/base.rb`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant