Pr/9 #10
Merged
Pr/9 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for Laravel authentication when users need to check their emails to connect
Actually is forced to use `_id`
merge from upstream
…odecov [refactor] Replaced Coveralls with Codecov
…dd-use-new-library-for-coveralls
[hotfix] The Mongo version in CI for 4.0 uses actually the 4
…r-coveralls Update ci file and composer dependencies
[refactor] Readme
(cherry picked from commit 16a1121)
(cherry picked from commit 1115bf5)
Add MorphMany relation to replaced whereIn method.
[Updated PR#1746] Add MustVerifyEmail
HasOne / HasMany must respect $localKey parameter
[Updated PR#1746] Add MustVerifyEmail
…bute Merged from halaei:fix-test-asser-object-not-has-attribute
[Updated PR#1468] Fix assertObjectNotHasAttribute cannot test magic attributes
divine
pushed a commit
that referenced
this pull request
Aug 24, 2023
…eject invalid array (#10) The Query\Builder::whereBetween() method can be used like this: whereBetween('date_field', [min, max]) whereBetween('date_field', collect([min, max])) whereBetween('date_field', CarbonPeriod) Laravel allows other formats: the $values array is flatten and the builder assumes there are at least 2 elements and ignore the others. It's a design that can lead to misunderstandings. I prefer to raise an exception when we have incorrect values, rather than trying to guess what the developer would like to do. Support for CarbonPeriod was fixed in Laravel 10: laravel/framework#46720 because the query builder was taking the 1st 2 values of the iterator instead of the start & end dates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.