Skip to content

Fix name resolution #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Fix name resolution #206

merged 1 commit into from
Sep 27, 2019

Conversation

pySilver
Copy link
Contributor

@pySilver pySilver commented Sep 26, 2019

elasticsearch_dsl.index.Index cannot be casted to string, _name property should be used instead.

Otherwise you'll see this in console:
Are you sure you want to delete the '<elasticsearch_dsl.index.Index object at 0x106d95e50>' indexes? [n/Y]: y

Expected:
Are you sure you want to delete the 'index_name_here' indexes? [n/Y]: y

elasticsearch_dsl.index.Index cannot be casted to string, `_name` property should be used instead.
@safwanrahman
Copy link
Collaborator

Looks good. r+

@safwanrahman safwanrahman merged commit 1072bcf into django-es:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants