Handle case where SimpleLazyObject being treated as an Iterable #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hemache Thanks for your PR. I am thinking about the situation where the SimpleLazyObject is a ctually a iterable, in the scenario, it will not work. |
|
@hemache Sorry for asking you, will you have some time to make the changes? |
|
@hemache, do you need some help ? |
|
hi guy, I'm really sorry I didn't have time to work on this lately, I would appreciate any help you could provide |
Co-Authored-By: Safwan Rahman <[email protected]>
|
@safwanrahman you're right, I accepted your suggested changes. |
safwanrahman
reviewed
Apr 8, 2020
|
Also, first line: |
Co-Authored-By: Safwan Rahman <[email protected]>
|
LGTM. r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #155