Skip to content

Set default_app_config only in Django 3.1 or less #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2021

Conversation

alexgmin
Copy link
Contributor

https://docs.djangoproject.com/en/3.2/releases/3.2/#automatic-appconfig-discovery

default_app_config is deprecated starting in 3.2, so a project in that version using this library with Deprecation Warnings enabled gets a warning about it.

This pull request sets the variable only if the django version is previous to 3.2

@safwanrahman
Copy link
Collaborator

LGTM! r+
Thanks @alexgmin

@safwanrahman safwanrahman merged commit ed4e603 into django-es:master Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants