Skip to content

Tested against Django 3.1 and 3.2 #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

jramnai
Copy link
Contributor

@jramnai jramnai commented Sep 4, 2021

Description

  • Tested against Django 3.1
  • Tested against Django 3.2
  • Updated Classifiers
  • Add DEFAULT_AUTO_FIELD to test settings and example project

Related Issue

see django/django@b5e12d4

Copy link
Contributor

@saadmk11 saadmk11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! 💯

@safwanrahman Can you please approve the GitHub Actions workflow for this PR so that the test suite can run with the new changes?

@safwanrahman
Copy link
Collaborator

@saadmk11 Thanks for mentioning. I did not know it needs to be approved before running the workflow. I have approved it. Lets see how it runs.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #371 (e17eca0) into master (0cc33bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   67.81%   67.81%           
=======================================
  Files          12       12           
  Lines         755      755           
=======================================
  Hits          512      512           
  Misses        243      243           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc33bb...e17eca0. Read the comment docs.

@safwanrahman
Copy link
Collaborator

It did not pass some of the tests. Can you check and fix them?

@jramnai
Copy link
Contributor Author

jramnai commented Sep 9, 2021

@safwanrahman, all tests are passing on the local machine.

Can not understand what is going wrong with GitHub CI, can you provide some pointer over here?

@saadmk11
Copy link
Contributor

I think we need to change self.category1.icon to self.category1.icon.url on the tests.

https://github.com/django-es/django-elasticsearch-dsl/pull/371/checks?check_run_id=3529815779#step:8:27

@jramnai
Copy link
Contributor Author

jramnai commented Sep 16, 2021

I think we need to change self.category1.icon to self.category1.icon.url on the tests.

@saadmk11, I have tried it out on another branch but it is still failing (out of clue now).

https://github.com/jramnai/django-elasticsearch-dsl/runs/3575713174?check_suite_focus=true#step:8:24

@saadmk11
Copy link
Contributor

I think we need to change self.category1.icon to self.category1.icon.url on the tests.

@saadmk11, I have tried it out on another branch but it is still failing (out of clue now).

https://github.com/jramnai/django-elasticsearch-dsl/runs/3575713174?check_suite_focus=true#step:8:24

There is one remaining
https://github.com/jramnai/django-elasticsearch-dsl/blob/e0c82a6ee55412c934f223976c6a9e7586c6cb02/tests/test_integration.py#L167

@jramnai
Copy link
Contributor Author

jramnai commented Sep 17, 2021

@safwanrahman, workflow is waiting for your approval.

@natabene
Copy link

@safwanrahman Could you please trigger the workflow on this PR? I would really appreciate if you can do this as soon as possible, it would help us very much with Django 3.2 upgrade for our Open edX Platform.

@safwanrahman
Copy link
Collaborator

@natabene @jramnai Sorry, I missed the notification.

@safwanrahman
Copy link
Collaborator

safwanrahman commented Sep 28, 2021

@jramnai Failed again! 😢

@safwanrahman
Copy link
Collaborator

@jramnai Can you rebase upon master and force push your branch? The test has been fixed.

@natabene
Copy link

natabene commented Oct 4, 2021

@jramnai Do you think you could address this in the next day? I would highly appreciate.

@jramnai
Copy link
Contributor Author

jramnai commented Oct 5, 2021

@safwanrahman, just rebased on top of master. Can you please run the workflow?

@awais786
Copy link

awais786 commented Oct 6, 2021

@safwanrahman Please merge and release the latest version Thanks.

@natabene
Copy link

natabene commented Oct 7, 2021

@safwanrahman Could you please merge and release today or tomorrow? We really would appreciate this as this is crucial for us here at Open edX team to prepare for the next Open edX release which will be cut in 2 days.

@safwanrahman safwanrahman merged commit 0e92e01 into django-es:master Oct 7, 2021
@safwanrahman
Copy link
Collaborator

LGTM. Thanks @jramnai. @natabene I am not sure about making a release today or tomorrow as I have come to holiday. You can install it with the git hash like pip install https://github.com/django-es/django-elasticsearch-dsl/archive/0e92e01c6ef74d2fe329965deee5f4b25da7ec87.tar.gz

@jramnai jramnai deleted the django-upgrade branch October 9, 2021 05:35
@natabene
Copy link

@safwanrahman Thanks so much, this helped us to get things out of the door in time. At the same time a new release would be highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants