-
Notifications
You must be signed in to change notification settings - Fork 270
Tested against Django 3.1 and 3.2 #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! 💯
@safwanrahman Can you please approve the GitHub Actions workflow for this PR so that the test suite can run with the new changes?
@saadmk11 Thanks for mentioning. I did not know it needs to be approved before running the workflow. I have approved it. Lets see how it runs. |
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
=======================================
Coverage 67.81% 67.81%
=======================================
Files 12 12
Lines 755 755
=======================================
Hits 512 512
Misses 243 243 Continue to review full report at Codecov.
|
It did not pass some of the tests. Can you check and fix them? |
@safwanrahman, all tests are passing on the local machine. Can not understand what is going wrong with GitHub CI, can you provide some pointer over here? |
I think we need to change |
@saadmk11, I have tried it out on another branch but it is still failing (out of clue now). |
There is one remaining |
d70ec1d
to
2ee3007
Compare
@safwanrahman, workflow is waiting for your approval. |
@safwanrahman Could you please trigger the workflow on this PR? I would really appreciate if you can do this as soon as possible, it would help us very much with Django 3.2 upgrade for our Open edX Platform. |
@jramnai Failed again! 😢 |
@jramnai Can you rebase upon master and force push your branch? The test has been fixed. |
@jramnai Do you think you could address this in the next day? I would highly appreciate. |
2ee3007
to
e17eca0
Compare
@safwanrahman, just rebased on top of master. Can you please run the workflow? |
@safwanrahman Please merge and release the latest version Thanks. |
@safwanrahman Could you please merge and release today or tomorrow? We really would appreciate this as this is crucial for us here at Open edX team to prepare for the next Open edX release which will be cut in 2 days. |
@safwanrahman Thanks so much, this helped us to get things out of the door in time. At the same time a new release would be highly appreciated. |
Description
DEFAULT_AUTO_FIELD
to test settings and example projectRelated Issue
see django/django@b5e12d4