Skip to content

Update doc about an error of CLI command #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Update doc about an error of CLI command #751

merged 1 commit into from
Dec 19, 2016

Conversation

zepouet
Copy link
Contributor

@zepouet zepouet commented Nov 23, 2016

Just correct a minor error about CLI.

Thanks

@zepouet zepouet changed the title Update doc Update doc about an error of CLI command Nov 23, 2016
@yosifkit
Copy link
Member

This needs to go in content.md; README.md is generated.

Just correct a minor error about CLI.

Thanks
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@jsternberg jsternberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commands that are already there work for me. It also appears like using --net=container:influxdb and using localhost also works. I intentionally didn't use --link because the documentation indicated that --link was an old feature and wasn't the preferred method of doing things.

Unless there's a strong reason to use the old method rather than the new one and unless I see that the current documentation results in an error, I'm not sure why this change should be used instead.

@tianon
Copy link
Member

tianon commented Dec 12, 2016

It's worth noting that --link, while discouraged (given that it doesn't work cross-host) is not officially deprecated yet.

I personally like --link over --net container:xxx because it shows a more general pattern that's easier to adjust for other needs (such as creating a second interactive container in an existing cross-host docker network which is on a separate physical host from the initial container, thus making --net container:xxx impossible to use), and makes it clear that "localhost" connections aren't treated as special in some way (like MySQL can be configured to do, for example).

@jsternberg
Copy link
Contributor

Ok. Whatever you guys think would be the clearer documentation on the matter. The reason why I used --net=container:xxx was because I thought that was the preferred method and I also show examples of setting up a network later on. Adding an example of using --link sounds fine to me in that case.

@tianon tianon merged commit a373a49 into docker-library:master Dec 19, 2016
@tianon
Copy link
Member

tianon commented Dec 19, 2016

Thanks @jsternberg (and @zepouet)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants