Skip to content

Remove 8.3 branch, and add 8.5 branch with PHP 7.2 #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2018

Conversation

skyred
Copy link
Contributor

@skyred skyred commented Jan 4, 2018

Drupal 8.3 is no longer supported.

PHP 7.2 is now fully supported and the recommended version. Please see the release notes: https://www.drupal.org/project/drupal/releases/8.4.4

@tianon
Copy link
Member

tianon commented Jan 4, 2018

From that link:

Drupal 8.4.4 still has one remaining critical bug on PHP 7.2 which will be fixed by Drupal 8.5.0, to be released March 7 2018

Doesn't this mean we should wait until 8.5 to swap from 7.1 to 7.2?

@skyred
Copy link
Contributor Author

skyred commented Jan 5, 2018

Ah, the release notes were changed after I made this pull request. Let's wait until Drupal 8.5.x-alpha1 release, which is schedule for later this month.

@skyred skyred closed this Jan 5, 2018
@skyred
Copy link
Contributor Author

skyred commented Jan 5, 2018

This link shows the release notes were updated: https://www.drupal.org/node/2934241/revisions/view/10777131/10777792, which affects this PR

@skyred skyred changed the title Remove 8.3 branch, and use PHP 7.2 Remove 8.3 branch, and add 8.5 branch with PHP 7.2 Jan 19, 2018
@skyred skyred reopened this Jan 19, 2018
@skyred
Copy link
Contributor Author

skyred commented Jan 19, 2018

Drupal 8.5.0-alpha1 release notes: https://www.drupal.org/project/drupal/releases/8.5.0-alpha1

[8.4]='8 latest'
[8.5-rc]='rc'
[8.4]='8'
[8.5-rc]='rc latest'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything except this change seems pretty good to me -- I don't think it's reasonable to point drupal:latest to a pre-release.

@tianon tianon merged commit d64de89 into docker-library:master Jan 20, 2018
@tianon
Copy link
Member

tianon commented Jan 20, 2018

LGTM, thanks! 👍

@skyred skyred deleted the patch-32 branch January 21, 2018 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants