Skip to content
This repository was archived by the owner on Aug 22, 2020. It is now read-only.

Add "(Shared)Tags" validation #21

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Add "(Shared)Tags" validation #21

merged 1 commit into from
Jun 27, 2019

Conversation

tianon
Copy link
Member

@tianon tianon commented Jun 26, 2019

This is intended to help pre-empt issues like docker-library/official-images#6116 (comment). 👍

@tianon
Copy link
Member Author

tianon commented Jun 26, 2019

I temporarily reverted docker-library/official-images@da490b0 locally to test this, and here's what the output looks like:

failed fetching repo "library/adoptopenjdk"
cannot parse manifest in either format:
RFC 2822 error: Tags "8u212-b04-jre-hotspot-windowsservercore-ltsc2016, 8-jre-hotspot-windowsservercore-ltsc2016" has invalid (Shared)Tags: ""
Line-based error: manifest line missing '@': GitRepo: https://github.com/AdoptOpenJDK/openjdk-docker.git

@yosifkit yosifkit merged commit fed4653 into docker-library:master Jun 27, 2019
@yosifkit yosifkit deleted the invalid-tags branch June 27, 2019 00:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yosifkit yosifkit yosifkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianon @yosifkit