Skip to content

Remove android/arm from 1.4/cross since it's nontrivial to get the -marm compiler backend for it #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2014
Merged

Remove android/arm from 1.4/cross since it's nontrivial to get the -marm compiler backend for it #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion 1.4/cross/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ FROM golang:1.4rc1
# and canonically, see defs_OS_ARCH.h files in src/runtime
# https://code.google.com/p/go/source/browse?name=go1.4beta1#hg%2Fsrc%2Fruntime
ENV GOLANG_CROSSPLATFORMS \
android/arm \
darwin/386 darwin/amd64 \
dragonfly/386 dragonfly/amd64 \
freebsd/386 freebsd/amd64 freebsd/arm \
Expand All @@ -17,6 +16,9 @@ ENV GOLANG_CROSSPLATFORMS \
solaris/amd64 \
windows/386 windows/amd64

# TODO gcc: error: unrecognized command line option '-marm'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add this on top instead?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it makes sense when seeing the full diff. LGTM

# android/arm \

# ls src/runtime/defs_*_*.h | sed -r 's!^.*/defs_([^_]+)_([^_]+)[.]h$!\1/\2!'

# (set an explicit GOARM of 5 for maximum ARM compatibility)
Expand Down