Windows: improve consistency in install verify steps #302
+35
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very insignificant change, but it looked a bit cleaner;
Before this change:
Expanding ...
Removing ...
Updating PATH ...
Verifying install ...
git --version
git version 2.11.1.windows.1
Complete.
....
Expanding ...
Verifying install (go version) ...
go version go1.13 windows/amd64
Removing ...
Complete.
After this change:
Expanding ...
Removing ...
Updating PATH ...
Verifying install (git version) ...
git version 2.11.1.windows.1
Complete.
....
Expanding ...
Removing ...
Verifying install (go version) ...
go version go1.13 windows/amd64
Complete.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Love it, thank you! 👍❤️ |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Sep 7, 2019
Changes: - docker-library/golang@963918c: Merge pull request docker-library/golang#302 from thaJeztah/Dockerfile_nits - docker-library/golang@e52dbc6: Merge pull request docker-library/golang#301 from thaJeztah/update_mingit - docker-library/golang@3a993b6: Windows: improve consistency in install verify steps - docker-library/golang@081f537: Windows: update MinGit to 2.23.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very insignificant change, but it looked a bit cleaner 🙈 🤗 🚲 🏠
Before this change:
After this change: