Add go-wrapper support for Go 1.4 Custom Import Paths, relegating .godir support legacy and "second fiddle" #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dir support legacy and "second fiddle"
|
LGTM |
| @@ -46,12 +48,14 @@ if ! shift; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| dir="$(pwd -P)" | |||
| goBin="$(basename "$dir")" # likely "app" | |||
| goDir="$(go list -e -f '{{.ImportComment}}' 2>/dev/null || true)" | |||
There was a problem hiding this comment.
suprised you didn't went for a cryptic ternary oneliner :)
There was a problem hiding this comment.
Hahahaha, nawww, go list is the bomb. 👍
|
LGTM :) |
yosifkit
added a commit
that referenced
this pull request
Nov 26, 2014
Add go-wrapper support for Go 1.4 Custom Import Paths, relegating .godir support legacy and "second fiddle"
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Nov 26, 2014
- `docker-dev`: `1.3.2` - `golang`: support for Go 1.4 "Custom Import Paths" (docker-library/golang#32) - `python`: smaller and `--enable-shared` (docker-library/python#23); slim variants (docker-library/python#24) - `tomcat`: jre8 versions (docker-library/tomcat#5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
I haven't run
update.shyet in the spirit of making this easier to review. 👍