Skip to content

Update to use buildpack-deps:*-scm as the base #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2015

Conversation

tianon
Copy link
Member

@tianon tianon commented Jan 15, 2015

Fixes #37

@yosifkit
Copy link
Member

LGTM

@tianon
Copy link
Member Author

tianon commented Jan 15, 2015

cc @proppy

RUN apt-get update && apt-get install -y \
ca-certificates curl gcc libc6-dev make \
bzr git mercurial \
gcc libc6-dev make \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ca-certificates in jessie or buildpacks-micro?

@proppy
Copy link

proppy commented Jan 16, 2015

maybe we could add some docs/comments on why we depends on buildpack-deps and what it includes.

@tianon tianon force-pushed the buildpack-deps-micro branch from 2843327 to 2668a6b Compare January 22, 2015 00:37
@tianon tianon changed the title Update to use buildpack-deps:*-micro as the base Update to use buildpack-deps:*-scm as the base Jan 22, 2015
@tianon
Copy link
Member Author

tianon commented Jan 22, 2015

Ok. I've updated this to use the new (and more specific / well-defined) scm variant of buildpack-deps, which is much more exact about what is included. See https://registry.hub.docker.com/_/buildpack-deps/ for more information, especially about which packages we've got.

@tianon
Copy link
Member Author

tianon commented Jan 22, 2015

(under "What's included?")

@proppy
Copy link

proppy commented Jan 23, 2015

Nice, LGTM. Out of curiosity is there a specific reason to have "curl" && "wget" in the -curl variant?

@tianon
Copy link
Member Author

tianon commented Jan 23, 2015

Only that the size difference is reasonably close to negligible and then either is usable depending on personal user taste -- "curl" just seemed like an appropriate general name for "common HTTP(s) fetching tools" (like "scm" has all the common Source Control Management tools).

yosifkit added a commit that referenced this pull request Jan 23, 2015
Update to use buildpack-deps:*-scm as the base
@yosifkit yosifkit merged commit 304244c into docker-library:master Jan 23, 2015
@yosifkit yosifkit deleted the buildpack-deps-micro branch January 23, 2015 16:25
tianon added a commit that referenced this pull request Jan 26, 2015
tianon added a commit to infosiftr/stackbrew that referenced this pull request Jan 26, 2015
- `golang`: update to use `buildpack-deps:*-scm` (docker-library/golang#38)
- `mongo`: replace 2.8 with 3.0.0-rc6 (docker-library/mongo#19)
- `php`: 5.4.37, 5.5.21, 5.6.5
- `tomcat`: 8.0.18
- `wordpress`: use `/etc/hosts` instead of env (docker-library/wordpress#42) and add simple mysql-retry logic to entrypoint (docker-library/wordpress#48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include SSH for private git repos
3 participants