-
Notifications
You must be signed in to change notification settings - Fork 516
Update to use buildpack-deps:*-scm as the base #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use buildpack-deps:*-scm as the base #38
Conversation
LGTM |
cc @proppy |
RUN apt-get update && apt-get install -y \ | ||
ca-certificates curl gcc libc6-dev make \ | ||
bzr git mercurial \ | ||
gcc libc6-dev make \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is ca-certificates in jessie or buildpacks-micro?
maybe we could add some docs/comments on why we depends on buildpack-deps and what it includes. |
2843327
to
2668a6b
Compare
Ok. I've updated this to use the new (and more specific / well-defined) |
(under "What's included?") |
Nice, LGTM. Out of curiosity is there a specific reason to have "curl" && "wget" in the -curl variant? |
Only that the size difference is reasonably close to negligible and then either is usable depending on personal user taste -- "curl" just seemed like an appropriate general name for "common HTTP(s) fetching tools" (like "scm" has all the common Source Control Management tools). |
Update to use buildpack-deps:*-scm as the base
- `golang`: update to use `buildpack-deps:*-scm` (docker-library/golang#38) - `mongo`: replace 2.8 with 3.0.0-rc6 (docker-library/mongo#19) - `php`: 5.4.37, 5.5.21, 5.6.5 - `tomcat`: 8.0.18 - `wordpress`: use `/etc/hosts` instead of env (docker-library/wordpress#42) and add simple mysql-retry logic to entrypoint (docker-library/wordpress#48)
Fixes #37