Handle Empty initdb.d directory #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker-entrypoint.sh script does not currently handle the case where the docker-entrypoint-initdb.d directory is empty. This commit sets the nullglob shell option to cause the empty directory to glob to nothing. This change will fix the following confusing message from coming up during startup. ``` /usr/local/bin/docker-entrypoint.sh: ignoring /docker-entrypoint-initdb.d/* ```
|
Seems sane to me -- @ltangvald? |
|
LGTM. Thanks for the contribution! |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Aug 22, 2016
- `docker`: 1.12.1 - `drupal`: 8.2.0-beta2 - `memcached`: 1.4.31 - `mysql`: handle empty `initdb` directory (docker-library/mysql#200) - `percona`: 5.6.32, 5.5.51 - `php`: 5.6.25 - `python`: 3.6.0a4 (docker-library/python#144), `windowsservercore` (docker-library/python#142) - `rabbitmq`: fix SSL/`ERL_ARGS` (docker-library/rabbitmq#103) - `rocket.chat`: 0.37.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker-entrypoint.sh script does not currently handle the case where
the docker-entrypoint-initdb.d directory is empty. This commit sets the
nullglob shell option to cause the empty directory to glob to nothing.
This change will fix the following confusing message from coming up
during startup.