Automatically run mysql_upgrade for 8.0 image #416
Conversation
It is recommended to always run mysql_upgrade when upgrading MySQL, and it is required when upgrading from an older major version. Entrypoint script checks if mysql_upgrade has previously been run on the current version. If not it does a temporary startup and runs it.
| local tmpdir=$1 | ||
| chown mysql:mysql "$tmpdir" | ||
| # We use skip-grant-tables since we can't know the root credentials of existing databases | ||
| mysqld --skip-networking --pid-file="$tmpdir/mysqld.pid" --socket="$tmpdir/mysqld.sock" --daemonize --skip-grant-tables --log-error="$tmpdir/error.log" |
There was a problem hiding this comment.
This needs to use the same "$@" logic we use for the other place we start the daemon, doesn't it? (which is slightly complicated by it being a shell function and "$@" from the script itself being obscured)
Maybe we need to fully resolve what #402 starts (by functionalizing more parts of this file) so we can invoke the daemon in the same way (with a way to add --skip-grant-tables for this use case)?
There was a problem hiding this comment.
Yeah, I agree. I'll do some work on that first
|
Hi, |
|
This PR is no longer required as of MySQL 8.0.16: https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-16.html
|
|
For this image, the upgrade process is basically identical to the MySQL docs for upgrading the MySQL Server container: And since |
It is recommended to always run mysql_upgrade when upgrading
MySQL, and it is required when upgrading from an older major version.
Entrypoint script checks if mysql_upgrade has previously been run on the
current version. If not it does a temporary startup and runs it.
This should fix most issues related from latest tag having changed from 5.7 to 8.0