Switch from libedit back to readline #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, I cannot input UTF-8 characters, no matter what I set `LANG` to, but this fixes it such that `LANG=C.UTF-8` works again for inputting UTF-8 characters like `💩`.
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Aug 25, 2021
Changes: - docker-library/php@ed2fe97: Merge pull request docker-library/php#1187 from infosiftr/readline - docker-library/php@eee43f6: Switch from libedit back to readline
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Aug 26, 2021
Changes: - docker-library/php@2047c68: Merge pull request docker-library/php#1193 from infosiftr/combine - docker-library/php@0630924: Apply templates using single template - docker-library/php@b5f8bba: Combine templates to a single template to reduce duplication - docker-library/php@ed2fe97: Merge pull request docker-library/php#1187 from infosiftr/readline - docker-library/php@eee43f6: Switch from libedit back to readline
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Aug 26, 2021
Changes: - docker-library/php@e81ce1c: Update 8.0 to 8.0.10 - docker-library/php@cdb853c: Update 7.3 to 7.3.30 - docker-library/php@2047c68: Merge pull request docker-library/php#1193 from infosiftr/combine - docker-library/php@0630924: Apply templates using single template - docker-library/php@b5f8bba: Combine templates to a single template to reduce duplication - docker-library/php@ed2fe97: Merge pull request docker-library/php#1187 from infosiftr/readline - docker-library/php@eee43f6: Switch from libedit back to readline
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Aug 26, 2021
Changes: - docker-library/php@496cd2f: Update 7.4 to 7.4.23 - docker-library/php@e81ce1c: Update 8.0 to 8.0.10 - docker-library/php@cdb853c: Update 7.3 to 7.3.30 - docker-library/php@2047c68: Merge pull request docker-library/php#1193 from infosiftr/combine - docker-library/php@0630924: Apply templates using single template - docker-library/php@b5f8bba: Combine templates to a single template to reduce duplication - docker-library/php@ed2fe97: Merge pull request docker-library/php#1187 from infosiftr/readline - docker-library/php@eee43f6: Switch from libedit back to readline
mnapoli
added a commit
to brefphp/aws-lambda-layers
that referenced
this pull request
Jan 13, 2023
BTW we could use libedit for readline, but it appears to be a secondary alternative, and not without issues (e.g. docker-library/php#1187). Let's stick to readline.
mnapoli
added a commit
to brefphp/aws-lambda-layers
that referenced
this pull request
Jan 13, 2023
Both options seem to be acceptable, but we get readline out of the box on lambda, and there seems to be issues with libedit anyway (docker-library/php#1187)
phoenix933
pushed a commit
to phoenix933/aws-lambda-layers
that referenced
this pull request
Dec 3, 2023
BTW we could use libedit for readline, but it appears to be a secondary alternative, and not without issues (e.g. docker-library/php#1187). Let's stick to readline.
phoenix933
pushed a commit
to phoenix933/aws-lambda-layers
that referenced
this pull request
Dec 3, 2023
Both options seem to be acceptable, but we get readline out of the box on lambda, and there seems to be issues with libedit anyway (docker-library/php#1187)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, I cannot input UTF-8 characters, no matter what I set
LANGto, but this fixes it such thatLANG=C.UTF-8works again for inputting UTF-8 characters like💩.Fixes #375