Skip to content

Add rabbitmq-clusterer support #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add rabbitmq-clusterer support #131

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 6, 2017

rabbitmq-clusterer is a plugin created and maintained by the RabbitMQ
team to help facilitate clustering. It will automatically cluster nodes
without the need for the typical "stop_app, join_cluster, start_app"
dance. It can also start a cluster up from a completely stopped start
with no user intervention.

rabbitmq-clusterer is a plugin created and maintained by the RabbitMQ
team to help facilitate clustering. It will automatically cluster nodes
without the need for the typical "stop_app, join_cluster, start_app"
dance. It can also start a cluster up from a completely stopped start
with no user intervention.
@ghost
Copy link
Author

ghost commented Jan 6, 2017

I've made this PR to talk about clustering and possibly script extension. I understand this repo cannot be responsible for every conceivable plugin combination and respect that. However, there is a noticeable lack of clustering ability from the official rabbitmq image. I think clusterer can solve this problem.

I have been using rabbitmq-clusterer in docker in the Kolla project for over a year now. It works extremely well in containers. I have pushed this change to DockerHub in a different image which can be viewed here.

It shows how easy it can be to setup clustered rabbitmq. I would love to see this merge in some form, but really my goal is to show that there is a strong need for config customization. With proper config customization I would not need to duplicate the entire docker-entrypoint.sh like I do here

That said, I did spend a bit of time making this patch match the coding style already present in the official image, so I feel there may be a path forward to merge this in some form.

A quote from that page:

For a two node cluster, run:

docker run
-e RABBITMQ_ERLANG_COOKIE=12345
-e RABBITMQ_CLUSTERER_NODE_1="rabbtest,disc"
-e RABBITMQ_CLUSTERER_NODE_2="rabbtest2,disc"
-e RABBITMQ_CLUSTERER_GOSPEL_NODE="rabbtest"
--hostname rabbtest
--name rabbtest
-d samyaple/rabbitmq-clusterer

docker run
-e RABBITMQ_ERLANG_COOKIE=12345
-e RABBITMQ_CLUSTERER_NODE_1="rabbtest,disc"
-e RABBITMQ_CLUSTERER_NODE_2="rabbtest2,disc"
-e RABBITMQ_CLUSTERER_GOSPEL_NODE="rabbtest"
--hostname rabbtest2
--name rabbtest2
--link rabbtest
-d samyaple/rabbitmq-clusterer

@ghost ghost mentioned this pull request Jan 6, 2017
@michaelklishin
Copy link
Collaborator

Please bear in mind that as of the future 3.7.0 release, team RabbitMQ considers rabbitmq-clusterer to be unnecessary. It won't be abandoned overnight but there hasn't been any new development for a while and it is really unlikely that there will be in the future.

@ghost
Copy link
Author

ghost commented Jan 11, 2017

@michaelklishin yea ive been following 3.7.0 for a long while now. Looking forward too it.

Frankly, I just want a way to extend the entrypoint.sh without an entirely new container. With that, PRs like this and a few others wouldn't be needed and we could all go on using the official images.

@ghost
Copy link
Author

ghost commented Apr 11, 2017

#121

@ghost ghost closed this Apr 11, 2017
@ghost
Copy link
Author

ghost commented Apr 11, 2017

For those that see this, I started just binding in a new entrypoint.sh are run time (as well as the plugin i wanted).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants