Fix management SSL issues (needs separate "verify" and "fail_if_no_peer_cert" defaults) #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
force-pushed
the
fix-management-ssl
branch
from
8ac2fcd to
1648a56
Compare
| @@ -83,12 +113,24 @@ if [ "${#missingFiles[@]}" -gt 0 ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # set defaults for missing values (but only after we're done with all our checking so we don't throw any of that off) | |||
| for conf in "${allConfigKeys[@]}"; do | |||
There was a problem hiding this comment.
I guess this should really just loop over ${!configDefaults[@]}"
There was a problem hiding this comment.
(and thus skip the next two lines entirely)
…er_cert" defaults)
tianon
force-pushed
the
fix-management-ssl
branch
from
1648a56 to
01cebb7
Compare
|
LGTM |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jul 8, 2016
- `cassandra`: 3.0.8, 2.2.7, 2.1.15 - `golang`: 1.7rc1 (docker-library/golang#100) - `httpd`: add `alpine` variants (docker-library/httpd#26) - `percona`: 5.5.50 - `rabbitmq`: fix more SSL issues (bad defaults for management; docker-library/rabbitmq#97) - `tomcat`: add `alpine` variants (docker-library/tomcat#36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96