Ruby 2.2 Dockerfiles #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the 2.1 Dockerfiles, changing only env vars
|
The tagging comes from $ ./generate-stackbrew-library.sh
# maintainer: InfoSiftr <[email protected]> (@infosiftr)
1.9.3-p551: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 1.9
1.9.3: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 1.9
1.9: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 1.9
1: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 1.9
1.9.3-p551-onbuild: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 1.9/onbuild
1.9.3-onbuild: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 1.9/onbuild
1.9-onbuild: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 1.9/onbuild
1-onbuild: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 1.9/onbuild
2.0.0-p598: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.0
2.0.0: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.0
2.0: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.0
2.0.0-p598-onbuild: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.0/onbuild
2.0.0-onbuild: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.0/onbuild
2.0-onbuild: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.0/onbuild
2.1.5: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.1
2.1: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.1
2: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.1
latest: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.1
2.1.5-onbuild: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.1/onbuild
2.1-onbuild: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.1/onbuild
2-onbuild: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.1/onbuild
onbuild: git://github.com/docker-library/ruby@069e9f5f9aa4903f4a3cb4baf6325d08d9d366e6 2.1/onbuild
2.2.0-preview2: git://github.com/docker-library/ruby@fbd4ada5041e94754536d98449452aa3ebc25840 2.2
2.2.0: git://github.com/docker-library/ruby@fbd4ada5041e94754536d98449452aa3ebc25840 2.2
2.2: git://github.com/docker-library/ruby@fbd4ada5041e94754536d98449452aa3ebc25840 2.2
2.2.0-preview2-onbuild: git://github.com/docker-library/ruby@fbd4ada5041e94754536d98449452aa3ebc25840 2.2/onbuild
2.2.0-onbuild: git://github.com/docker-library/ruby@fbd4ada5041e94754536d98449452aa3ebc25840 2.2/onbuild
2.2-onbuild: git://github.com/docker-library/ruby@fbd4ada5041e94754536d98449452aa3ebc25840 2.2/onbuildThis looks good to me, though we may want to add a wheezy version to be consistent (just merged a PR for the other versions). |
|
Okay, cool. I've added 2.2 Wheezy Dockerfile to the branch |
|
LGTM |
|
ping @tianon and @Moghedrin |
|
LGTM diff --git a/2.1/Dockerfile b/-
index dcd0bcc..0000000 100644
--- a/2.1/Dockerfile
+++ b/-
@@ -2,8 +2,8 @@ FROM buildpack-deps:jessie
RUN apt-get update && apt-get install -y curl procps && rm -rf /var/lib/apt/lists/*
-ENV RUBY_MAJOR 2.1
-ENV RUBY_VERSION 2.1.5
+ENV RUBY_MAJOR 2.2
+ENV RUBY_VERSION 2.2.0-preview2
# some of ruby's build scripts are written in ruby
# we purge this later to make sure our final image uses what we just built |
|
LGTM |
chrissolanilla
pushed a commit
to chrissolanilla/CSolanillaBio
that referenced
this pull request
May 16, 2024
Update titles for team and update deploy pipeline to use correct Ruby Bundler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the 2.1 Dockerfiles, changing only env vars
Tested this locally on my boot2docker VM. I know the
2.2.0-preview2tag would have to be created in order for the onbuild Dockerfile to work, but I figured I'd throw this up here as proposal before I try to figure out how that tagging process should work...