Build dynamic library (libruby.so) #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems sane: https://sources.debian.net/src/ruby2.1/2.1.5-2%2Bdeb8u3/debian/rules/#L22 👍 I've pushed another commit to update the templates and thus all variants; as long as Travis comes back green, I think we're good to go! 🤘 |
Merged
|
docker-library/python#23 is further justification for this (beyond just that Debian enables this too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
libruby.soto the Ruby 2.1, 2.2, and 2.3 images by passing the--enable-sharedflag to the./configurecall.I ran into issues when trying to run a Ruby app with a native library that had to be linked against
libruby.soin Docker. Since the Ruby base image don't have it, I gotlibruby.so.2.3: cannot open shared object file: No such file or directory. This seems like a use-case that should probably be supported by the Ruby Docker images. Thus this PR.It seems to add a few megabytes to the image size (3.6, 3.4, 2.5 MB for Ruby 2.1, 2.2, and 2.3, respectively), but AFAICT it shouldn't have any adverse consequences otherwise.