-
Notifications
You must be signed in to change notification settings - Fork 1.1k
support setting WP_ALLOW_MULTISITE #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
&& rm wordpress.tar.gz | ||
|
||
# install language files | ||
RUN curl -s https://he.wordpress.org/wordpress-4.3.1-he_IL.tar.gz | tar -zx -C /usr/src/ --wildcards 'wordpress/wp-content/languages/*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think including hebrew (or other languages) into the official image is something we should do. You can easily do this by building your own image FROM the official image and adding the language files there.
IMO, this is pretty similar to #8 (and I'm really sorry for the delay in responding 😞); my reservations about it would be the same as those I have on #8 -- it's not included in the default |
} | ||
|
||
EOPHP | ||
[ -n "$WP_ALLOW_MULTISITE" ] && echo "define( 'WP_ALLOW_MULTISITE', true );" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is useful, but not necessary if docker-entrypoint.sh
would allow pulling in external snippets (i.e. from /etc/wordpress/*.php).
Why is it not merged yet?
…files to match wordpress version
refactor the additional PHP code for wp-config.php into a function to support more complicated setups, and implement support for setting WP_ALLOW_MULTISITE