Skip to content

Slevomat CS 7.0.0 and PHPCS 3.6.0 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2021
Merged

Slevomat CS 7.0.0 and PHPCS 3.6.0 #241

merged 1 commit into from
Apr 12, 2021

Conversation

kukulich
Copy link
Contributor

No description provided.

@kukulich kukulich requested a review from a team as a code owner April 12, 2021 11:13
@greg0ire greg0ire merged commit 35a2452 into doctrine:9.0.x Apr 12, 2021
@greg0ire
Copy link
Member

Thanks @kukulich !

@shadowhand
Copy link

Can we expect a tagged release today? 🙏

@ostrolucky
Copy link
Member

You could help convince us to do it if you explain what do you need from 7.0.0 that we are blocking you from

@morozov
Copy link
Member

morozov commented Apr 12, 2021

There are certain improvements in the Slevomat standard regarding PHP 8.1 support (e.g. slevomat/coding-standard#1171). Current Doctrine standard requires Slevomat ^6, so it's challenging to use it with PHP 8.1.

@shadowhand
Copy link

shadowhand commented Apr 12, 2021 •
edited
Loading

Current version of this package blocks the usage of PHP 8 features such as property promotion, which will result in two different errors errors, depending on number of indented spaces. This means that attempting to use property promotion will always result in a phpcs error. There are a variety of other issues related to PHP 8 that are solved in slevomat/coding-standard 7.0 and phpcs 3.6: match() (using phpcbf always breaks it), attributes, etc.

Our organization doesn't allow requiring of -dev packages, even for developer tooling.

@greg0ire greg0ire added this to the 9.0.0 milestone Apr 12, 2021
@greg0ire
Copy link
Member

Done: https://twitter.com/greg0ire/status/1381663675749171210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadowhand shadowhand shadowhand approved these changes

@morozov morozov morozov approved these changes

@simPod simPod simPod approved these changes

@ostrolucky ostrolucky ostrolucky approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kukulich @greg0ire @shadowhand @ostrolucky @morozov @simPod