Skip to content

Correct y-or-n-p snippet #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Correct y-or-n-p snippet #53

wants to merge 1 commit into from

Conversation

davidh38
Copy link

@davidh38 davidh38 commented Nov 4, 2020

This should be a correction for the Issue: Error on +snippet/edit #4127
I tried to reason about, what was the symbol-function should have achieved, but i could not find one. I would either love to find out about the reason or ask you to accept my pull request.

@hlissner hlissner closed this in e1cbbdf Nov 4, 2020
@hlissner
Copy link
Member

hlissner commented Nov 4, 2020

This was copied from the yasnippet snippets way, way back. I think the intention was for the snippet to use y-or-n-p if the user had "redefined" yes-or-no-p with it. e.g. (fset 'yes-or-no-p 'y-or-n-p). A common setting you'll find in Emacs users' configs, but this doesn't work for Doom because we advise it, instead of redefining it.

In any case, I've split it into two separate snippets, which should resolve both issues. Thanks for bringing it to my attention!

@hlissner hlissner added is:bug Something isn't working as intended mode:emacs-lisp labels Nov 4, 2020
github-actions bot added a commit to vlaci/nix-doom-emacs that referenced this pull request Nov 6, 2020
## Changelog for doom-snippets:
Commits: [doomemacs/snippets@d97c65ee...e1cbbdf5](doomemacs/snippets@d97c65e...e1cbbdf)

* [`e1cbbdf5`](doomemacs/snippets@e1cbbdf) Fix doomemacs/snippets#53: broken y-or-n-p snippets
vlaci pushed a commit to vlaci/nix-doom-emacs that referenced this pull request Nov 7, 2020
## Changelog for doom-snippets:
Commits: [doomemacs/snippets@d97c65ee...e1cbbdf5](doomemacs/snippets@d97c65e...e1cbbdf)

* [`e1cbbdf5`](doomemacs/snippets@e1cbbdf) Fix doomemacs/snippets#53: broken y-or-n-p snippets
vlaci pushed a commit to vlaci/nix-doom-emacs that referenced this pull request Dec 1, 2020
## Changelog for doom-snippets:
Commits: [doomemacs/snippets@d97c65ee...e1cbbdf5](doomemacs/snippets@d97c65e...e1cbbdf)

* [`e1cbbdf5`](doomemacs/snippets@e1cbbdf) Fix doomemacs/snippets#53: broken y-or-n-p snippets
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
is:bug Something isn't working as intended mode:emacs-lisp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants