Skip to content

nit(org-mode): remove duplicate quote snippet #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2022

Conversation

dschrempf
Copy link
Contributor

No description provided.

@dschrempf dschrempf force-pushed the org-remove-quote-duplicate branch from bb7aee2 to 29dc3d8 Compare March 14, 2022 15:36
Copy link
Member

@hlissner hlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This snippet is wanted and should not be removed. At the very least, quote should be an alias like begin_src is for src. E.g.

# -*- mode: snippet -*-
# name: #+begin_quote block
# key: <q
# uuid: <q
# --
(doom-snippets-expand :uuid "quote")

Can you change that instead?

@hlissner hlissner added is:feature Adds or requests new features, or extends existing ones mode:org labels Mar 21, 2022
@dschrempf dschrempf force-pushed the org-remove-quote-duplicate branch from 29dc3d8 to f5f5e1a Compare March 23, 2022 09:57
@dschrempf
Copy link
Contributor Author

dschrempf commented Mar 23, 2022

Done. I also added # type: command.

@dschrempf dschrempf requested a review from hlissner March 23, 2022 09:58
@hlissner hlissner added this to the v2.0 milestone May 3, 2022
@hlissner hlissner merged commit 697eeb9 into doomemacs:master May 3, 2022
@hlissner
Copy link
Member

hlissner commented May 3, 2022

Sorry for the tremendously late response. Thanks for your help!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
is:feature Adds or requests new features, or extends existing ones mode:org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants