Skip to content

fix(org-mode): change deprecated keyword #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2022

Conversation

dschrempf
Copy link
Contributor

Change label to name.

Also substitute colon, which throws a warning with org-lint.

Change `label` to `name`.

Also substitute colon, which throws a warning with `org-lint`.
@hlissner
Copy link
Member

It seems that #+name for figures is ignored if org-latex-prefer-user-labels is nil (which it is, by default). Can you confirm that this works for you when it's set to nil?

@hlissner hlissner added is:bug Something isn't working as intended mode:org labels Mar 21, 2022
@dschrempf
Copy link
Contributor Author

From my test (simple figure with simple reference), I can see:

org-latex-prefer-user-labels t; use #label:   Reference in PDF output works, but reference within Org mode does not work.
org-latex-prefer-user-labels t; use #name:    Reference in PDF output works, reference within Org mode works.
org-latex-prefer-user-labels nil; use #label: Reference in PDF output works, reference within Org mode does not work.
org-latex-prefer-user-labels nil; use #name:  Reference in PDF output works, reference within Org mode works.

So it is definitely best to use #name.

I hope this helps!

@hlissner hlissner added this to the v2.0 milestone May 3, 2022
@hlissner hlissner merged commit 2940baa into doomemacs:master May 3, 2022
@hlissner
Copy link
Member

hlissner commented May 3, 2022

Thanks again!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
is:bug Something isn't working as intended mode:org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants