Skip to content

fix(org-mode): Rename code snippet to begin #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dschrempf
Copy link
Contributor

Org now uses begin_src LANGUAGE, which is also provided in this package.

Copy link
Member

@hlissner hlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not what this snippet was for. Org supports various #+begin_X blocks, like #+begin_example, #+begin_verse, #+begin_latex, or #+begin_src. Dozens more if you use org-special-block-extras. This snippet exists as a generic "block" snippet; left to the user to fill in.

Granted, the placeholders (and snippet) are poorly named; that should be corrected instead. E.g. rename it to begin and use:

# -*- mode: snippet -*-
# name: begin
# --
#+begin_${1:type} ${2:options}
`(%)`$0
#+end_$1

@hlissner hlissner added is:feature Adds or requests new features, or extends existing ones mode:org labels Mar 21, 2022
@dschrempf dschrempf force-pushed the org-mode-rm-deprecated-snippets branch from 4a3468e to 1450f06 Compare March 23, 2022 09:51
@dschrempf
Copy link
Contributor Author

I renamed the code snippet to begin now.

I was not aware of these special blocks, thanks for bringing them to my attention.

The only block I don't think is necessary is the begin_latex block, see my comment at #86

@dschrempf dschrempf requested a review from hlissner March 23, 2022 09:53
@dschrempf dschrempf changed the title fix(org-mode): Remove deprecated code snippet fix(org-mode): Rename code snippet to begin Mar 23, 2022
@hlissner hlissner added is:tweak Code changes that affects user-facing behavior and removed is:feature Adds or requests new features, or extends existing ones labels May 3, 2022
@hlissner hlissner added this to the v2.0 milestone May 3, 2022
@hlissner hlissner merged commit cc26b6b into doomemacs:master May 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
is:tweak Code changes that affects user-facing behavior mode:org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants