Skip to content

snippet(cc): improve for #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

snippet(cc): improve for #91

wants to merge 1 commit into from

Conversation

externalxdpro
Copy link
Contributor

@externalxdpro externalxdpro commented Sep 8, 2022

Made the variable names change all at once, theoretically improving efficiency.
Edit: Also added "int" before "i", since a for loop requires it.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

⚠️ This pull request was automatically marked stale because it was inactive for 60 days. If this PR is still valid, please reply to it or it will be closed in 7 days.

@github-actions github-actions bot added the stale No response, forgotten, or abandoned label Nov 9, 2022
@github-actions github-actions bot closed this Nov 16, 2022
@hlissner hlissner reopened this Nov 16, 2022
@hlissner hlissner added mode:c++ mode:c is:tweak Code changes that affects user-facing behavior and removed stale No response, forgotten, or abandoned labels Nov 16, 2022
@hlissner hlissner added this to the v2.0 milestone Nov 16, 2022
@hlissner hlissner added the was:moved Is or was addressed elsewhere label Feb 19, 2023
@hlissner hlissner closed this in fe40030 Feb 19, 2023
@hlissner
Copy link
Member

hlissner commented Feb 19, 2023

Sorry for the tremendously late response; this slipped under my radar. I wanted to err on the side of simplicity for the snippets with shorter trigger keywords (or trigger keywords that match its language's keywords), and the formatting doesn't match our other snippets (I'll later add some logic to auto-correct the brace placement depending on the butter's settings, btw), so I've split out the indexed for-loop into a separate fori snippet in fe40030, among other things. In any case, thanks for the PR and for bringing it to my attention!

@externalxdpro externalxdpro deleted the improve-for-snippet branch February 20, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:tweak Code changes that affects user-facing behavior mode:c++ mode:c was:moved Is or was addressed elsewhere
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants