Skip to content

Commit 4aad754

Browse files
authored
skip Libuv.FunctionalTests RemoteIPv6Address on Helix (#8111)
1 parent 6e8a9f6 commit 4aad754

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/Servers/Kestrel/test/FunctionalTests/RequestTests.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,9 @@ public Task RemoteIPv4Address()
136136

137137
[ConditionalFact]
138138
[IPv6SupportedCondition]
139+
#if LIBUV
140+
[SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/8109
141+
#endif
139142
public Task RemoteIPv6Address()
140143
{
141144
return TestRemoteIPAddress("[::1]", "[::1]", "::1");

src/Servers/Kestrel/test/Libuv.FunctionalTests/Libuv.FunctionalTests.csproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
44
<TargetFramework>netcoreapp3.0</TargetFramework>
55
<DefineConstants Condition="$([MSBuild]::IsOSPlatform('OSX'))">$(DefineConstants);MACOS</DefineConstants>
6+
<DefineConstants>$(DefineConstants);LIBUV</DefineConstants>
67
<ServerGarbageCollection>true</ServerGarbageCollection>
78
<!-- Put this project into its own test group to avoid running parallel with other test projects. Libuv does not play nice with other test assemblies. -->
89
<TestGroupName>Libuv.FunctionalTests</TestGroupName>
@@ -11,6 +12,7 @@
1112
<ItemGroup>
1213
<Compile Include="..\FunctionalTests\**\*.cs" />
1314
<Compile Include="$(SharedSourceRoot)NullScope.cs" />
15+
<Compile Include="$(SharedSourceRoot)test\SkipOnHelixAttribute.cs" />
1416
<Compile Include="$(KestrelSharedSourceRoot)test\*.cs" LinkBase="shared" />
1517
<Compile Include="$(KestrelSharedSourceRoot)test\TransportTestHelpers\*.cs" LinkBase="shared\TransportTestHelpers" />
1618
<Content Include="$(KestrelSharedSourceRoot)test\TestCertificates\*.pfx" LinkBase="shared\TestCertificates" CopyToOutputDirectory="PreserveNewest" />

0 commit comments

Comments
 (0)