Skip to content

skip Libuv.FunctionalTests RemoteIPv6Address on Helix #8111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2019
Merged

skip Libuv.FunctionalTests RemoteIPv6Address on Helix #8111

merged 2 commits into from
Mar 2, 2019

Conversation

analogrelay
Copy link
Contributor

related #8109

@analogrelay analogrelay requested review from Tratcher and HaoK March 1, 2019 21:54
@analogrelay analogrelay requested a review from jkotalik as a code owner March 1, 2019 21:54
HaoK
HaoK approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@HaoK HaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this is the main offender, I have a vague recollection of seeing similar tests in here fail before, but I might have skipped them already, cross our fingers I guess

@analogrelay
Copy link
Contributor Author

If another one shows up, I'll disable the entire project :).

@analogrelay
Copy link
Contributor Author

I messed something up. I thought it was building on my machine but I was wrong :).

@analogrelay
Copy link
Contributor Author

Figured it out, the file is also used in Sockets tests. I'm adding some #ifdef fun.

@analogrelay analogrelay requested review from Eilon and HaoK March 1, 2019 22:12
HaoK
HaoK approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@HaoK HaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah these tests are all shared, so slightly more annoying to disable

@HaoK
Copy link
Member

HaoK commented Mar 1, 2019

Generally I've only seen the libuv bind/functional tests fail (and usually only on non windows, so the flakiness is limited somewhat)

@analogrelay analogrelay merged commit 4aad754 into master Mar 2, 2019
@analogrelay analogrelay deleted the anurse/8109-skip-kestrel-libuv-test branch May 1, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoK HaoK HaoK approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@jkotalik jkotalik Awaiting requested review from jkotalik

@Eilon Eilon Awaiting requested review from Eilon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@analogrelay @HaoK @Eilon