Skip to content

Commit 7efec87

Browse files
authored
Fix fetch of package version in eng/Publishing.props (#24777)
- target project is a test project; need to undo `$(SkipTestBuild)` impact in these jobs nit: remove a comment from DeveloperCertificates project that's irrelevant now
1 parent cd58eb7 commit 7efec87

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

eng/Publishing.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
C# or F# project. For now at least, C# and F# projects should not be referenced when using desktop msbuild.
3939
-->
4040
<MSBuild Projects="$(RepoRoot)src\SignalR\clients\ts\FunctionalTests\SignalR.Npm.FunctionalTests.npmproj"
41-
Properties="DisableYarnCheck=true"
41+
Properties="DisableYarnCheck=true;ExcludeFromBuild=false"
4242
Targets="_GetPackageVersionInfo"
4343
SkipNonexistentProjects="false">
4444
<Output TaskParameter="TargetOutputs" ItemName="_ResolvedPackageVersionInfo" />

src/Tools/FirstRunCertGenerator/src/Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88

99
<!-- This package contains API for the .NET CLI to generate the aspnet HTTPs dev cert during CLI first-run initialization. -->
1010

11-
<!-- Our publishing logic depends on this particular package being NonShipping - if this ever becomes a Shipping project, we will incorrectly calculate the repo's version string,
12-
which will cause us to publish installers & checksums to the wrong place. If this ever becomes a Shipping project, we also need to update the following line to reference a different NonShipping project:
13-
https://github.com/dotnet/aspnetcore/blob/6301eefbc346b9ef00ede83ce223d8240b71942a/eng/Publishing.props#L39 -->
1411
<IsShippingPackage>false</IsShippingPackage>
1512
<ExcludeFromSourceBuild>false</ExcludeFromSourceBuild>
1613
</PropertyGroup>

0 commit comments

Comments
 (0)