Skip to content

Fix fetch of package version in eng/Publishing.props #24777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Aug 11, 2020

  • target project is a test project; need to undo $(SkipTestBuild) impact in these jobs

nit: remove a comment from DeveloperCertificates project that's irrelevant now

- target project is a test project; need to undo `$(SkipTestBuild)` impact in these jobs

nit: remove a comment from DeveloperCertificates project that's irrelevant now
@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 11, 2020
@dougbu dougbu requested a review from a team August 11, 2020 05:24
@dougbu
Copy link
Contributor Author

dougbu commented Aug 11, 2020

Should help close dotnet/core-eng#10415 though I still have some questions there. Should also unblock publication in our official builds.

@dougbu
Copy link
Contributor Author

dougbu commented Aug 11, 2020

@dougbu
Copy link
Contributor Author

dougbu commented Aug 11, 2020

Test internal build (with some added debug Message tasks and binary logs) worked: https://dev.azure.com/dnceng/internal/_build/results?buildId=764739

@dougbu
Copy link
Contributor Author

dougbu commented Aug 11, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu dougbu merged commit 7efec87 into master Aug 11, 2020
@dougbu dougbu deleted the dougbu/publish.fixups branch August 11, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants