Skip to content

Commit 7f7a5e9

Browse files
Fix custom elements JS initializer not being included in build output (#54931)
* Fix custom elements IncludeCompileJsOutput target * Unquarantine tests
1 parent d7109b1 commit 7f7a5e9

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/Components/CustomElements/src/Microsoft.AspNetCore.Components.CustomElements.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk.Razor">
1+
<Project Sdk="Microsoft.NET.Sdk.Razor">
22

33
<PropertyGroup>
44
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
@@ -18,7 +18,7 @@
1818
</ResolveStaticWebAssetsInputsDependsOn>
1919
</PropertyGroup>
2020

21-
<Target Name="IncludeCompileJsOutput" BeforeTargets="_ResolveJsModuleInputs">
21+
<Target Name="IncludeCompileJsOutput" BeforeTargets="ResolveJSModuleStaticWebAssets">
2222
<ItemGroup>
2323
<_JsBuildOutput Include="$(InteropWorkingDir)dist\$(Configuration)\**" Exclude="$(InteropWorkingDir)dist\.gitignore" />
2424
</ItemGroup>

src/Components/test/E2ETest/Tests/CustomElementsTest.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ public void CanAddAndRemoveCustomElements()
5555
}
5656

5757
[Fact]
58-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54889")]
5958
public void CanUpdateSimpleParameters()
6059
{
6160
app.FindElement(By.Id("add-custom-element")).Click();
@@ -106,7 +105,6 @@ void ValidateSimpleParameterValues(int id, int clickCount)
106105
}
107106

108107
[Fact]
109-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54889")]
110108
public void CanUpdateComplexParameters()
111109
{
112110
app.FindElement(By.Id("add-custom-element")).Click();

0 commit comments

Comments
 (0)