Skip to content

Fix custom elements JS initializer not being included in build output #54931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

MackinnonBuck
Copy link
Member

Fixes an issue where the IncludeCompileJsOutput target was running too late, so the custom elements JS initializer wasn't getting included correctly in the build output.

Fixes #54889

@MackinnonBuck MackinnonBuck requested a review from javiercn April 3, 2024 17:50
@MackinnonBuck MackinnonBuck requested a review from a team as a code owner April 3, 2024 17:50
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Apr 3, 2024
@MackinnonBuck MackinnonBuck merged commit 7f7a5e9 into main Apr 3, 2024
@MackinnonBuck MackinnonBuck deleted the mbuck/fix-custom-elements branch April 3, 2024 22:15
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarantine CanUpdateComplexParameters and CanUpdateSimpleParameters
2 participants