Make OIDC handler skip unrecognized requests (#10060)

Author: mderriey

src/Security/Authentication/OpenIdConnect/src/OpenIdConnectHandler.cs

@@ -515,7 +515,7 @@ protected override async Task<HandleRequestResult> HandleRemoteAuthenticateAsync
                 authorizationResponse = messageReceivedContext.ProtocolMessage;
                 properties = messageReceivedContext.Properties;
 
-                if (properties == null)
+                if (properties == null || properties.Items.Count == 0)
                 {
                     // Fail if state is missing, it's required for the correlation id.
                     if (string.IsNullOrEmpty(authorizationResponse.State))

src/Security/Authentication/test/OpenIdConnect/OpenIdConnectAuthenticateTests.cs

@@ -0,0 +1,67 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System.Collections.Generic;
+using System.Net.Http;
+using System.Threading.Tasks;
+using Microsoft.AspNetCore.Http;
+using Xunit;
+
+namespace Microsoft.AspNetCore.Authentication.Test.OpenIdConnect
+{
+    public class OpenIdConnectAuthenticateTests
+    {
+        [Fact]
+        public async Task RegularGetRequestToCallbackPathSkips()
+        {
+            // Arrange
+            var settings = new TestSettings(
+                opt =>
+                {
+                    opt.Authority = TestServerBuilder.DefaultAuthority;
+                    opt.CallbackPath = new PathString("/");
+                    opt.SkipUnrecognizedRequests = true;
+                    opt.ClientId = "Test Id";
+                });
+
+            var server = settings.CreateTestServer(handler: async context =>
+            {
+                await context.Response.WriteAsync("Hi from the callback path");
+            });
+
+            // Act
+            var transaction = await server.SendAsync("/");
+
+            // Assert
+            Assert.Equal("Hi from the callback path", transaction.ResponseText);
+        }
+
+        [Fact]
+        public async Task RegularPostRequestToCallbackPathSkips()
+        {
+            // Arrange
+            var settings = new TestSettings(
+                opt =>
+                {
+                    opt.Authority = TestServerBuilder.DefaultAuthority;
+                    opt.CallbackPath = new PathString("/");
+                    opt.SkipUnrecognizedRequests = true;
+                    opt.ClientId = "Test Id";
+                });
+
+            var server = settings.CreateTestServer(handler: async context =>
+            {
+                await context.Response.WriteAsync("Hi from the callback path");
+            });
+
+            // Act
+            var request = new HttpRequestMessage(HttpMethod.Post, "/");
+            request.Content = new FormUrlEncodedContent(new Dictionary<string, string>());
+
+            var transaction = await server.SendAsync(request, cookieHeader: null);
+
+            // Assert
+            Assert.Equal("Hi from the callback path", transaction.ResponseText);
+        }
+    }
+}

src/Security/Authentication/test/OpenIdConnect/TestServerExtensions.cs

@@ -16,9 +16,13 @@ public static Task<TestTransaction> SendAsync(this TestServer server, string url
             return SendAsync(server, url, cookieHeader: null);
         }
 
-        public static async Task<TestTransaction> SendAsync(this TestServer server, string uri, string cookieHeader)
+        public static Task<TestTransaction> SendAsync(this TestServer server, string url, string cookieHeader)
+        {
+            return SendAsync(server, new HttpRequestMessage(HttpMethod.Get, url), cookieHeader);
+        }
+
+        public static async Task<TestTransaction> SendAsync(this TestServer server, HttpRequestMessage request, string cookieHeader)
         {
-            var request = new HttpRequestMessage(HttpMethod.Get, uri);
             if (!string.IsNullOrEmpty(cookieHeader))
             {
                 request.Headers.Add("Cookie", cookieHeader);