Make OIDC handler skip unrecognized requests #10060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need this because during the MessageReceived event, the null AuthenticationProperties created from the non-existent OIDC message are swapped with a new instance when we new up the MessageReceivedContext.
|
I couldn't find tests against the OIDC handler for the Authenticate flow to make sure that this is not breaking existing behavior. |
|
OIDC has some significant test gaps. #4681 |
Tratcher
approved these changes
May 8, 2019
|
This comment was made automatically. If there is a problem contact [email protected]. I've triaged the above build. I've created/commented on the following issue(s) |
|
Thanks |
|
Thank you, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkipUnrecognizedRequestsproperty by skipping them, as they currently throwAddresses #10028